Commit f922ab92 authored by Sli's avatar Sli

Merge branch 'bugfix' into 'master'

counter: fix error for stats 500 on PermissionDenied

See merge request !208
parents d466d645 f0524a9f
Pipeline #1801 passed with stage
in 30 minutes and 18 seconds
......@@ -83,6 +83,17 @@ class CounterTest(TestCase):
)
class CounterStatsTest(TestCase):
def setUp(self):
call_command("populate")
self.counter = Counter.objects.filter(id=2).first()
def test_unothorized_user_fail(self):
# Test with not login user
response = self.client.get(reverse("counter:stats", args=[self.counter.id]))
self.assertTrue(response.status_code == 403)
class BarmanConnectionTest(TestCase):
def setUp(self):
call_command("populate")
......
......@@ -1522,11 +1522,11 @@ class CounterStatView(DetailView, CounterAdminMixin):
def dispatch(self, request, *args, **kwargs):
try:
return super(CounterStatView, self).dispatch(request, *args, **kwargs)
except:
except PermissionDenied:
if (
request.user.is_root
or request.user.is_board_member
or self.object.is_owned_by(request.user)
or self.get_object().is_owned_by(request.user)
):
return super(CanEditMixin, self).dispatch(request, *args, **kwargs)
raise PermissionDenied
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment