Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Sith
Sith
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 59
    • Issues 59
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • AE
  • SithSith
  • Issues
  • #106

Closed
Open
Opened Apr 28, 2020 by tleb@tlebDeveloper

Matmatronch search type on certain fields

The matmatronch search is done using __icontains on every field. It is not appropriate on fields such as promo where a search of "9" will return results in promo 9 and 19. 19!

icontains is also not necessary on some other fields, such as role or department (which are enums). Not sure if it matters though. The only aspect I can see where it might change something is performance. Do we care though (micro-optimisations, etc.)?

See matmat.views.SearchFormListView::get_queryset().

Edited Apr 28, 2020 by tleb
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: ae/Sith#106