Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Sith Sith
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 14
    • Issues 14
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • AE UTBM
  • SithSith
  • Merge requests
  • !250

Merged
Created Oct 16, 2019 by tleb@tlebContributor

Remove unused multiple-select library

  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 5

Remove the multiple-select library as it seems it it not used:

// unrelated
$ grep -r --exclude-dir=.git multiple-select .
./env/lib/python3.6/site-packages/django/contrib/admin/static/admin/js/SelectFilter2.js:SelectFilter2 - Turns a multiple-select box into a filter interface.


// nothing
$ grep -r --exclude-dir=.git select_single .


// only .html files from a dependency, no CSS class
$ grep -r --exclude-dir=.git select_multiple .
./env/lib/python3.6/site-packages/djangorestframework-3.10.3.dist-info/RECORD:rest_framework/templates/rest_framework/horizontal/select_multiple.html,sha256=C_98qhJwLTMNfbFBn6nhD3Qjdp6tcHwq82d8S3pFwSw,1229
./env/lib/python3.6/site-packages/djangorestframework-3.10.3.dist-info/RECORD:rest_framework/templates/rest_framework/inline/select_multiple.html,sha256=3zoyMlBWFNDVT7yI-zgN3lMVPGmWOBRKB6-Qyzlu174,917
./env/lib/python3.6/site-packages/djangorestframework-3.10.3.dist-info/RECORD:rest_framework/templates/rest_framework/vertical/select_multiple.html,sha256=97Rtt11FQHTX0yk-ksj3dchMXO7BBC2U4_6WZqqpegI,1184
Binary file ./env/lib/python3.6/site-packages/rest_framework/__pycache__/renderers.cpython-36.pyc matches
./env/lib/python3.6/site-packages/rest_framework/renderers.py:            'base_template': 'select_multiple.html',  # Also valid: 'checkbox_multiple.html'
./env/lib/python3.6/site-packages/rest_framework/renderers.py:            'base_template': 'select_multiple.html',  # Also valid: 'checkbox_multiple.html'


// nothing
$ grep -r --exclude-dir=.git "\<SelectSingle\>" .


// ajax_select has a SelectMultiple class but it does not seem linked
$ grep -r --exclude-dir=.git "\<SelectMultiple\>" .
./env/lib/python3.6/site-packages/ajax_select/fields.py:class AutoCompleteSelectMultipleWidget(forms.widgets.SelectMultiple):
./env/lib/python3.6/site-packages/django/forms/widgets.py:    'NullBooleanSelect', 'SelectMultiple', 'RadioSelect',
./env/lib/python3.6/site-packages/django/forms/widgets.py:class SelectMultiple(Select):
./env/lib/python3.6/site-packages/django/forms/fields.py:    NullBooleanSelect, NumberInput, Select, SelectMultiple,
./env/lib/python3.6/site-packages/django/forms/fields.py:    widget = SelectMultiple
./env/lib/python3.6/site-packages/django/forms/models.py:    HiddenInput, MultipleHiddenInput, SelectMultiple,
./env/lib/python3.6/site-packages/django/forms/models.py:    widget = SelectMultiple
Binary file ./env/lib/python3.6/site-packages/django/forms/__pycache__/widgets.cpython-36.pyc matches
Binary file ./env/lib/python3.6/site-packages/django/forms/__pycache__/models.cpython-36.pyc matches
./env/lib/python3.6/site-packages/django/contrib/admin/options.py:from django.forms.widgets import CheckboxSelectMultiple, SelectMultiple
./env/lib/python3.6/site-packages/django/contrib/admin/options.py:        if (isinstance(form_field.widget, SelectMultiple) and
./env/lib/python3.6/site-packages/django/contrib/admin/widgets.py:class FilteredSelectMultiple(forms.SelectMultiple):
./env/lib/python3.6/site-packages/django/contrib/admin/widgets.py:    A SelectMultiple with a JavaScript filter interface.
./env/lib/python3.6/site-packages/django/contrib/admin/widgets.py:class AutocompleteSelectMultiple(AutocompleteMixin, forms.SelectMultiple):
Binary file ./env/lib/python3.6/site-packages/django/contrib/admin/__pycache__/widgets.cpython-36.pyc matches
Binary file ./env/lib/python3.6/site-packages/django/contrib/admin/__pycache__/options.cpython-36.pyc matches

This needs to be checked! I don't know the codebase, it could be loaded dynamically by concatenation or other (wtf though?). The multiple select inputs look like this.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cleanup-forms